Simplify editor "ternary button" structure #23542
GitHub Actions / Results
failed
Jan 9, 2025 in 0s
43238 passed, 2 failed and 312 skipped
| Report | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| TestResults-Linux-MultiThreaded.trx | 10809✅ | 1❌ | 78⚪ | 2388s |
| TestResults-Linux-SingleThread.trx | 10809✅ | 1❌ | 78⚪ | 2004s |
| TestResults-Windows-MultiThreaded.trx | 10810✅ | 78⚪ | 3047s | |
| TestResults-Windows-SingleThread.trx | 10810✅ | 78⚪ | 2515s |
❌ TestResults-Linux-MultiThreaded.trx
10888 tests were completed in 2388s with 10809 passed, 1 failed and 78 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| osu.Game.Rulesets.Osu.Tests.TestSceneSpinnerRotation | 9✅ | 1❌ | 21s |
❌ osu.Game.Rulesets.Osu.Tests.TestSceneSpinnerRotation
✅ TestConstructor
✅ TestRotationDirection(False)
✅ TestRotationDirection(True)
✅ TestSpinnerCompleteBonusRewinding
✅ TestSpinnerMiddleRewindingRotation
✅ TestSpinnerNormalBonusRewinding
✅ TestSpinnerRewindingRotation
❌ TestSpinPerMinuteOnRewind
spm still valid: Expected: 477.53119590728693d +/- 1.0d
But was: 463.84197617799447d
Off by: 13.689219729292461d
✅ TestSpinUnaffectedByClockRate(0.5d)
✅ TestSpinUnaffectedByClockRate(2.0d)
❌ TestResults-Linux-SingleThread.trx
10888 tests were completed in 2004s with 10809 passed, 1 failed and 78 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation | 39✅ | 1❌ | 7s |
❌ osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation
✅ TestAddAudioTrack
✅ TestAddAudioTrack
✅ TestBackgroundFileChangesPreserveOnEncode
✅ TestBackgroundFileChangesPreserveOnEncode
✅ TestConstructor
✅ TestConstructor
✅ TestCopyDifficulty
✅ TestCopyDifficulty
✅ TestCopyDifficultyDoesNotChangeCollections
✅ TestCopyDifficultyDoesNotChangeCollections
✅ TestCreateMultipleNewDifficultiesSucceeds
✅ TestCreateMultipleNewDifficultiesSucceeds
✅ TestCreateNewBeatmap
✅ TestCreateNewBeatmap
✅ TestCreateNewDifficulty(False)
✅ TestCreateNewDifficulty(False)
✅ TestCreateNewDifficulty(True)
✅ TestCreateNewDifficulty(True)
✅ TestCreateNewDifficultyForInconvertibleRuleset
✅ TestCreateNewDifficultyForInconvertibleRuleset
✅ TestCreateNewDifficultyWithScrollSpeed_DifferentRuleset
❌ TestCreateNewDifficultyWithScrollSpeed_DifferentRuleset
System.ArgumentOutOfRangeException : Index must be within the bounds of the List. (Parameter 'index')
✅ TestCreateNewDifficultyWithScrollSpeed_SameRuleset
✅ TestCreateNewDifficultyWithScrollSpeed_SameRuleset
✅ TestExitBlockedWhenSavingBeatmapWithSameNamedDifficulties
✅ TestExitBlockedWhenSavingBeatmapWithSameNamedDifficulties
✅ TestExitWithoutSave
✅ TestExitWithoutSave
✅ TestMultipleAudioFiles
✅ TestMultipleAudioFiles
✅ TestMultipleBackgroundFiles
✅ TestMultipleBackgroundFiles
✅ TestSavingBeatmapFailsWithSameNamedDifficulties(False)
✅ TestSavingBeatmapFailsWithSameNamedDifficulties(False)
✅ TestSavingBeatmapFailsWithSameNamedDifficulties(True)
✅ TestSavingBeatmapFailsWithSameNamedDifficulties(True)
✅ TestSingleAudioFile
✅ TestSingleAudioFile
✅ TestSingleBackgroundFile
✅ TestSingleBackgroundFile
✅ TestResults-Windows-MultiThreaded.trx
10888 tests were completed in 3047s with 10810 passed, 0 failed and 78 skipped.
✅ TestResults-Windows-SingleThread.trx
10888 tests were completed in 2515s with 10810 passed, 0 failed and 78 skipped.
Annotations
Check failure on line 166 in osu.Game.Rulesets.Osu.Tests/TestSceneSpinnerRotation.cs
github-actions / Results
osu.Game.Rulesets.Osu.Tests.TestSceneSpinnerRotation ► TestSpinPerMinuteOnRewind
Failed test found in:
TestResults-Linux-MultiThreaded.trx
Error:
spm still valid: Expected: 477.53119590728693d +/- 1.0d
But was: 463.84197617799447d
Off by: 13.689219729292461d
Raw output
spm still valid: Expected: 477.53119590728693d +/- 1.0d
But was: 463.84197617799447d
Off by: 13.689219729292461d
at osu.Game.Rulesets.Osu.Tests.TestSceneSpinnerRotation.TestSpinPerMinuteOnRewind() in /home/runner/work/osu/osu/osu.Game.Rulesets.Osu.Tests/TestSceneSpinnerRotation.cs:line 166
Check failure on line 144 in osu.Game/Beatmaps/ControlPoints/ControlPointInfo.cs
github-actions / Results
osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation ► TestCreateNewDifficultyWithScrollSpeed_DifferentRuleset
Failed test found in:
TestResults-Linux-SingleThread.trx
Error:
System.ArgumentOutOfRangeException : Index must be within the bounds of the List. (Parameter 'index')
Raw output
System.ArgumentOutOfRangeException : Index must be within the bounds of the List. (Parameter 'index')
at osu.Framework.Bindables.BindableList`1.insert(Int32 index, T item, HashSet`1 appliedInstances)
at osu.Framework.Bindables.BindableList`1.insert(Int32 index, T item, HashSet`1 appliedInstances)
at osu.Game.Beatmaps.ControlPoints.ControlPointInfo.GroupAt(Double time, Boolean addIfNotExisting) in /home/runner/work/osu/osu/osu.Game/Beatmaps/ControlPoints/ControlPointInfo.cs:line 144
at osu.Game.Beatmaps.ControlPoints.ControlPointInfo.Add(Double time, ControlPoint controlPoint) in /home/runner/work/osu/osu/osu.Game/Beatmaps/ControlPoints/ControlPointInfo.cs:line 125
at osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.<>c__DisplayClass20_0.<TestCreateNewDifficultyWithScrollSpeed_DifferentRuleset>b__4() in /home/runner/work/osu/osu/osu.Game.Tests/Visual/Editing/TestSceneEditorBeatmapCreation.cs:line 276
at osu.Framework.Testing.Drawables.Steps.SingleStepButton.clickAction()
at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`2 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /home/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 541
at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
Loading