Skip to content
This repository has been archived by the owner on Dec 29, 2023. It is now read-only.

Github workflows are run in duplicate on push and PR triggers #10

Open
ethanjli opened this issue Jan 30, 2021 · 0 comments
Open

Github workflows are run in duplicate on push and PR triggers #10

ethanjli opened this issue Jan 30, 2021 · 0 comments
Assignees
Labels
domain: repo On the repository itself type: fix Iterations on existing features or infrastructure work: complicated The situation is complicated (known unknowns), good practices used

Comments

@ethanjli
Copy link
Member

ethanjli commented Jan 30, 2021

As can be seen for example in PR #9 on the checks for commit c8351b0, when a PR is created, it gets executed twice: once for the push trigger and once for the pull request trigger. Ideally, it would only be executed for the pull request trigger. There are two options:

  • It might be possible to use the Skip Duplicate Actions to prevent the push trigger from running if the pull request trigger has already run
  • Or maybe we will only enable the push trigger on the develop and production branches, and running the workflow on a feature branch can only be triggered either manually or with a PR. This might be a simpler solution, but it would prevent workflow success/failure from being associated with the commit.
@ethanjli ethanjli added type: fix Iterations on existing features or infrastructure domain: repo On the repository itself labels Jan 30, 2021
@ethanjli ethanjli self-assigned this Jan 30, 2021
@ethanjli ethanjli added the work: complicated The situation is complicated (known unknowns), good practices used label Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
domain: repo On the repository itself type: fix Iterations on existing features or infrastructure work: complicated The situation is complicated (known unknowns), good practices used
Projects
None yet
Development

No branches or pull requests

1 participant