Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend output #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extend output #6

wants to merge 2 commits into from

Conversation

vquie
Copy link

@vquie vquie commented Dec 20, 2017

Add report_id to output.

@prbinu
Copy link
Owner

prbinu commented Jan 3, 2018

Hi, Thanks for the PR, and sorry for late response.

The output is a KV pair, separated by ','. So wondering why do we need to put quotes around org name.

@malvidin
Copy link

malvidin commented Jan 9, 2018

We recently transitioned to primarily exporting JSON to address multiple issues we found in our KV extractions, which would also address any issues with fields that contain commas inappropriately

@malvidin
Copy link

malvidin commented Jan 9, 2018

For example, records that contain multiple DKIM results

@prbinu
Copy link
Owner

prbinu commented Jan 10, 2018

The script is filtering ',' chars from the value. Is this not sufficient:

org_name = (elem.findtext("org_name", 'NULL')).translate(None, ',')

Ref: https://github.com/vquiering/dmarc-report-processor/blob/c91c878190faa9e6c28730a4a56332a94e7c3f11/bin/dmarc-parser.py#L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants