Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start script & option for config template #55

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Conversation

w-ensink
Copy link
Contributor

We need the option to provide a config template to this issuer, as the config depends on secrets from different places and we want to be able to change those secrets without needing to redeploy the whole issuer.

This PR adds allows you to provide a config.json file in the form of a template and fill in the gaps using environment variables.

Using this mechanism only the pods need restarting, which can easily be done without redeploying.

Simple example

If you want to set a password based on an env var:

{
    "mail_password": "$MAIL_PASSWORD"
}

And then pass the MAIL_PASSWORD env var when starting the Docker container.

@w-ensink w-ensink requested a review from jappe999 January 13, 2025 14:24
jappe999
jappe999 previously approved these changes Jan 13, 2025
Copy link

@jappe999 jappe999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Got one (possible) improvement.

start.sh Outdated Show resolved Hide resolved
@w-ensink w-ensink merged commit b843a34 into master Jan 13, 2025
6 checks passed
@w-ensink w-ensink deleted the config-template branch January 13, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants