Adding a Gradle Build system to the Processing IDE #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screen.Recording.2024-12-18.at.09.14.01.movLittle preview of the new splash screen and the tweak to the macOS titlebar Before Screen.Recording.2024-12-18.at.09.16.56.mov |
Stefterv
commented
Dec 18, 2024
Stefterv
commented
Dec 18, 2024
| errStr = DefaultErrorLocalStrSet.get().get("editor.status.error.syntax").orElse("Error"); | ||
| retStr = DefaultErrorLocalStrSet.get().get(stringName).orElse(stringName); | ||
| } | ||
| var errStr = DefaultErrorLocalStrSet.get().get("editor.status.error.syntax").orElse("Error"); |
There was a problem hiding this comment.
Still not sure how to fix this
Stefterv
commented
Dec 18, 2024
| new File(resourcesFolder, "en.lproj")); | ||
| Util.copyFile(mode.getContentFile("application/application.icns"), | ||
| new File(resourcesFolder, "application.icns")); | ||
| // TODO: Handle the java embed and Icon with the new build system |
Stefterv
commented
Dec 18, 2024
The Processing Website has more meta-data related to the examples. I'd like to use that meta-data going forward so I've added it
Screen.Recording.2024-12-18.200843.mp4Windows adjusted titlebar |
Suhailmo99
previously approved these changes
Dec 18, 2024
SableRaf
dismissed
Suhailmo99’s stale review
This PR is not ready for review.
Using the work by @mingness to simplify the contributions workflow. Disabled the post request because that data is not saved anywhere and most hosts do not support it
Stefterv
commented
Jan 9, 2025
Stefterv
commented
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the first pull-request adding a new Gradle build system to the Processing IDE.
The GitHub Actions will create distributable binaries for macOS (x64, aarch64), windows (x64) and linux (x64). The other platforms will need their own CI/CD system, but I think the repo will already build on the other platforms.
In terms of compatibility I've come pretty far but I'm sure there is some functionality that I have missed.
New Features
Functionality to test and verify
processing-javaTo add during this pull request
https://github.com/JetBrains/compose-multiplatform/blob/master/tutorials/Native_distributions_and_local_execution/README.md#customizing-infoplist-on-macos
https://github.com/JetBrains/compose-multiplatform/blob/master/tutorials/Signing_and_notarization_on_macOS/README.md#configuring-entitlements
To improve during this pull request
After pull request
https://github.com/JetBrains/compose-multiplatform/blob/master/tutorials/Signing_and_notarization_on_macOS/README.md
This will require a custom runner setup as jetpack compose does not cross-build
To consider
In any case, this pull request does not break the existing Ant build system so we can either wait with the merge or we can have the Gradle version available as a preview.
The bundle size has increased quite a bit since we are shipping a JRE and a JDK instead of using the JDK to run the IDE
|linux-x64 | 257 MB |
|macos-aarch64 | 294 MB |
|macos-x64 | 289 MB |
|windows-x64 | 275 MB |
P.S. this also includes the pre-processor as a Maven library, so merging this PR will add processing:java:prepocessor as a Maven package