Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe some TCP settings should be configureable :
see https://erlang.org/doc/man/inet.html#setopts-2
NOTE: The SSLOpts variable in p1_mysql_conn may be renamed Opts or Options
"proplists:get_bool(prop, Opts)" calls could be replace by "get_option(prop, Opts, false)" calls
"get_option" works even if some properties are not keyvalues, for instance :
get_option(ssl_required, [keepalive, {send_timeout, 5000}, {ssl_required, true}], false).
true