Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-validate submodules when labels are modified #37101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −2
Open

Re-validate submodules when labels are modified #37101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2bccdc
Re-validate submodules when labels are modified
arkq Jan 17, 2025
7773420
Reformat help text
arkq Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/third-party-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ on:
paths:
- "third_party/**"
- ".gitmodules"
types: [opened, synchronize, reopened, labeled, unlabeled]

jobs:
check-submodule-update-label:
Expand All @@ -32,7 +33,7 @@ jobs:
run: |
echo This pull request attempts to update submodules without the changing-submodules-on-purpose label. Please apply that label if the changes are intentional, or remove those changes.
exit 1
- if: ${{ contains(github.event.pull_request.labels.*.name, 'changing-submodules-on-purpose') }}
- if: ${{ contains(github.event.pull_request.labels.*.name, 'changing-submodules-on-purpose') }}
name: Success
run: |
echo PR looks good.
Expand Down
3 changes: 2 additions & 1 deletion third_party/tizen/tizen_qemu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@
help=("host directory to share with the guest"))
parser.add_argument(
'--runner', type=str,
help=("path to the runner script which will run automatically after boot. path should be relative to shared directory"))
help=("path to the runner script which will be executed after boot; "
"it should be relative to the shared directory"))
parser.add_argument(
'--output', metavar='FILE', default="/dev/null",
help="store the QEMU output in a FILE")
Expand Down
Loading