Adding asset compilation + Access to rails console #33
Conversation
|
Will get rid of the else block and rename the asset function, also like the message difference between the docker output and builder output, but is this the template we are going to use ? |
|
@mfojtik I have updated the PR. Pls review |
jhadvig
changed the title
|
looks good to me, @jwforres any thoughts about assets compilation support in the ruby base image? |
| } | ||
|
|
||
| function has_assets(){ | ||
| ! grep " execjs " Gemfile.lock >/dev/null && return 1 |
There was a problem hiding this comment.
User may already have compiled their assets and not want the builder to do it for them.
There was a problem hiding this comment.
And I don't think we can assume that they will use asset compilation gems that require execjs
There was a problem hiding this comment.
@smarterclayton, yes they may, but also they may not have the assets precompiled. In openshift 2.0 we use the disable_asset_compilation marker to disable the precompilation. Wasn't sure how to disable the precompilation in a dockerish way, cause we would need to introduce some kind of convention, which we don't want.
Any tip on that ?
@jwforres yes we can't but if the application is a rails app, in order to precompile the assets the app Gemfile needs to contains a JavaScript runtime (rubyracer, therubyrhino, ...) which will also install execjs as a dependency and so it will be located in the Gemfile.lock.
Thats why I also check in the rake_assets_precompile function that the app is a rails app.
It is similar approach like we use right now in the ruby cartridge.
|
What's the state of this? |
|
@smarterclayton The state is that it should be working, although it is quite different from the ruby-19-centos image that we provide in the openshift repository. |
Asset precompilation support for Rails applications.