Add "catalog list" command #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice addition, thanks for the contribution! 👍 May I suggest to add a |
srueg
approved these changes
Sep 14, 2020
simu
approved these changes
Sep 14, 2020
chrisglass
force-pushed
the
add-catalog-list-command-rebased
branch
from
a568a12 to
2900afc
Compare
This commit adds the "commodore catalog list" command that will query lieutenant for a list of available cluster IDs (and descriptions), and display the information on stdout.
chrisglass
force-pushed
the
add-catalog-list-command-rebased
branch
from
2900afc to
96f1558
Compare
Don't print out non-machine-readable information if the output is not "verbose". By default, only the cluster IDs will be printed, allowing scripted usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the "commodore catalog list" command that will query
lieutenant for a list of available cluster IDs (and descriptions), and
display the information on stdout.
This partially helps with #135
Checklist
Testing done
Unit tests have not been added since the logic is trivial (basically printing out contents of an already-existing API) and consists mostly of stiching side-effects. Mocking side-effects (the click library and lieutenant function call) would result it unit testing a for loop, which I suspect is not very interesting.