Merge pull request #42 from projectsyn/feat/pin-image-versions

Use static versions for `acme-dns` and `caddy` container images
projectsyn · Sep 28, 2022 · 1b5e39d · 1b5e39d
2 parents 9c3ef2b + 55d4cab
commit 1b5e39d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/class/defaults.yml b/class/defaults.yml
@@ -9,14 +9,17 @@ parameters:
       acme-dns:
         registry: docker.io
         repository: joohoi/acme-dns
-        tag: latest
+        tag: v1.0
       caddy:
         registry: docker.io
         repository: caddy/caddy
-        tag: alpine
+        tag: 2.6.1-alpine
       sqlite:
         registry: docker.io
         repository: nouchka/sqlite3
+        # We use the sqlite3 image for K8up-based backups. Unfortunately
+        # there's no tags other than latest for the nouchka/sqlite3 image, so
+        # we're using latest here.
         tag: latest
 
     api:

diff --git a/tests/golden/defaults/acme-dns/acme-dns/acme-dns/20_deployment.yaml b/tests/golden/defaults/acme-dns/acme-dns/acme-dns/20_deployment.yaml
@@ -28,8 +28,8 @@ spec:
       containers:
         - args: []
           env: []
-          image: docker.io/joohoi/acme-dns:latest
-          imagePullPolicy: Always
+          image: docker.io/joohoi/acme-dns:v1.0
+          imagePullPolicy: IfNotPresent
           livenessProbe:
             failureThreshold: 3
             httpGet:
@@ -68,7 +68,7 @@ spec:
             - --config
             - /etc/caddy/caddy.json
           env: []
-          image: docker.io/caddy/caddy:alpine
+          image: docker.io/caddy/caddy:2.6.1-alpine
           imagePullPolicy: IfNotPresent
           livenessProbe:
             failureThreshold: 3
@@ -109,7 +109,7 @@ spec:
           envFrom:
             - secretRef:
                 name: acmedns-basicauth
-          image: docker.io/caddy/caddy:alpine
+          image: docker.io/caddy/caddy:2.6.1-alpine
           imagePullPolicy: IfNotPresent
           name: render-caddy-config
           ports: []