Extend allInstances with the component names of instantiated components
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
changed the title
allInstances with the component names for instantiated componentsallInstances with the component names of instantiated components
…ents The design doc (SDD-0030) specifies that entries in `syn.<team>.instances` must be component instances. However, Commodore doesn't require that instance-aware components generate an ArgoCD application per instance, and some existing components generate a single ArgoCD application for all their instances. For such components, individual instances can't be assigned to a team, but the whole component can be assigned. To accommodate this design choice, we keep both the instance and component names in `allInstances` for instantiated components. This ensures that library consumers can correctly look up the team for a component which generates a single ArgoCD application for all instances.
simu
force-pushed
the
feat/component-team-assignment
branch
from
b7cd6f4 to
2ad079a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design doc (SDD-0030) specifies that entries in
syn.<team>.instancesmust be component instances.However, Commodore doesn't require that instance-aware components generate an ArgoCD application per instance, and some existing components generate a single ArgoCD application for all their instances.
For such components, individual instances can't be assigned to a team, but the whole component can be assigned.
To accommodate this design choice, we keep both the instance and component names in
allInstancesfor instantiated components. This ensures that library consumers can correctly look up the team for a component which generates a single ArgoCD application for all instances.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.