Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Simon Gerber <[email protected]>
  • Loading branch information
HappyTetrahedron and simu authored Aug 6, 2024
1 parent 1913a8d commit 1236c7a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions docs/modules/ROOT/pages/explanations/cicd-support.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This feature is designed to support the https://github.com/projectsyn/commodore-

[NOTE]
--
Automatic configuration of CI/CD tooling is so far only supported on GitLab.
Currently, automatic configuration of CI/CD tooling is only supported on GitLab.

To allow the Lieutenant Operator to connect to GitLab, refer to xref:how-tos/gitlab-connection.adoc[Connection to GitLab].
--
Expand Down Expand Up @@ -36,5 +36,6 @@ In particular, the following parameters are provided on a tenant where `spec.com

The CI/CD pipeline can use these parameters to compile cluster catalogs with Commodore, and push them to the corresponding catalog repositories.
The https://github.com/projectsyn/commodore-compile-pipelines[Commodore Compile Pipeline] is a GitLab CI pipeline definition which accomplishes that.
However, it is possible to use other CI/CD systems.
If the available CI pipeline definition isn't suitable for your use case, you can deploy an arbitrary valid `.gitlab-ci.yml` through the `pipelineFiles` mechanism.
Please note that Lieutenant doesn't check the validity of the files provided in `pipelineFiles`.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ This page explains how to set up the https://github.com/projectsyn/commodore-com

[NOTE]
--
Automatic configuration of CI/CD tooling is so far only supported on GitLab.
Currently, automatic configuration of CI/CD tooling is only supported on GitLab.

To allow the Lieutenant Operator to connect to GitLab, refer to xref:how-tos/gitlab-connection.adoc[Connection to GitLab].
--
Expand Down

0 comments on commit 1236c7a

Please sign in to comment.