Explicitly set preserveUnknownFields to false
#270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a leftover from pre `v1` lieutenant. CRDs had the API version `v1beta1` which, when converted to `v1`, set `preserveUnknownFields=true`. Since the field was never explicitly managed it stayed on clusters that had lieutenant `< v1` installed and was false on clusters that never used a `< v1` lieutenant. The introduction of kubebuilder defaults with the upgrade of k8s.io/api/core broke old installations since defaults are not compatible with `preserveUnknownFields=true`. This commit explicitly sets `preserveUnknownFields` to `false` in all CRDs. Commit changing API version: 8839a08
simu
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a leftover from pre-
v1lieutenant. CRDs had the API versionv1beta1which, when converted tov1, setpreserveUnknownFields=true. Since the field was never explicitly managed it stayedtrueon clusters that had lieutenant< v1installed and was false on clusters that never used a< v1lieutenant.The introduction of kubebuilder defaults with the upgrade of
k8s.io/api/core brokeold installations since defaults are not compatible withpreserveUnknownFields=true.This commit explicitly sets
preserveUnknownFieldstofalsein all CRDs.Commit changing API version: 8839a08
Dependency upgrade: 2d59a4c#diff-3399214b42d027ec91b2533bc7401c1b69aa8bbf96f2870840cc03ca2d0ebebdR184
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog