-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSR Logger plugin messages accuracy improvements #75
Conversation
Pull Request Test Coverage Report for Build 245
💛 - Coveralls |
b3156b1
to
1341e59
Compare
Hello, I've just rebased this branch to include earliest Have you had the chance to give some thoughts about it @UFOMelkor ? Thanks! |
@gquemener Do you know how to fix the failing tests? Can be done in a separate PR, if you think that's better Edit: Ok, did not see your issue: #79 |
@codeliner I think it's worth it to deal with the issue #79 in another PR. My guess is that it's a mix of Symfony / Prooph bundle bugs. Furthermore, the testsuite is already broken on master, so merging this PR will not hurt. I keep investigating. |
1341e59
to
5559b0b
Compare
🤔 @gquemener I've merged the open PRs and fixed a conflict in this PR. My hope was that pipeline is green now but master is broken as well as your PR. Any ideas? Would like to do one last release for this package, before we stop supporting it. |
Hello @codeliner, The whole testsuite is broken due to some changes within Symfony DI. It looks like these changes were not BC, and I am not sure if this is a problem in the version constraints that are set in the However, I've started to fill holes on a branch. I guess I need a few weeks to fix all this mess on my spare time. How long d'you give me? ^^ |
Closing due to inactivity |
Several messages were in the present tense whereas they should be in the past tense.
The logged message was inaccurate in case of an event dispatching:
I've also wrapped all message names with double quotes.