-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Packaging #65
Merged
Merged
Update Packaging #65
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
21f2742
Updates for packaging
cherbel 1fd9edd
Refactor server to use new npm package, remove app
cherbel cc7f549
Fixing and consolidating types
cherbel c801de7
Consolidate package.json for server, some more cleanup
cherbel ab63382
Cleaning up types
cherbel 2fc654d
Bugfix, remove tsconfig, update readme
cherbel 7b8a688
Remove old tsconfig, update readme
cherbel 2fe52d5
v0.0.4
cherbel 424b402
Address PR Feedback
cherbel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,4 +15,5 @@ python-sdk/dist/ | |
python-sdk/build/ | ||
.pytest_cache/ | ||
python-sdk/.pytest_cache/ | ||
.vscode | ||
.vscode | ||
server/.env.local |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is called in our github workflow:
https://github.com/protectai/rebuff/blob/main/.github/workflows/python_tests.yaml#L27-L28
https://github.com/protectai/rebuff/blob/main/python-sdk/tests/conftest.py#L21-L58
Which stands up the server for python-sdk tests (and subsequently tests ingration with the server -- now pinned to a specific release). Ultimately we should replace this setup with unit testing individual TS functions but for the time being is there a need to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added it back, although I removed the
npm install
, because theinit-server
step runs the install in the server directory, and there is no longer a package.json in the root directory.