Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility improvements #93

Merged
merged 3 commits into from
Jan 6, 2025
Merged

accessibility improvements #93

merged 3 commits into from
Jan 6, 2025

Conversation

bdon
Copy link
Member

@bdon bdon commented Jan 5, 2025

All interactive elements should have a role, name and value. The input fields in the Cost Calculator don’t have a name (label). A screen reader will read for example ‘Edit selected 12,000,000’ but doesn’t say what information the user is providing or why. The same problem occurs on the slider: the screen reader will only read ‘Slider 1.2 + 07’.

Addressed by adding the required tags.

The navigation menu has nested interactive controls, because of this the navigation is harder to control for people with a visibility or mobility disability. For more information, see also nested-interactive by Accessibility Insights.

See vitepress issue 3806 below.

You can’t reach the scrollable regions that include code snippets when using the keyboard. By using ‘tab’ on your keyboard, you should be able to cycle through all interactive elements on the page.

Keyboard scrolling on overflow divs seems to work on Chromium for Mac, but not Safari/Firefox:
CleanShot 2025-01-06 at 17 06 40@2x

The contrast between foreground and background is not sufficient for grey text (#6D737C) within code snippet boxes. The minimum contrast should be 3:1.

Changed to high-contrast versions of the syntax themes.

The state of the navigation menu toggles cannot be determined programmatically: it does not contain a value or indication whether it is collapsed or expanded.

See vitepress issue 3806 below.

When you use the keyboard to navigate through the menu, there are 2 buttons with the same action:
the text, for example ‘introduction’ and the arrow pointing down. Both these clickable buttons expand
the list of navigation items below. This might cause unnecessary confusion for people who use their
keyboard and/or a screen reader to use the page, because they can’t easily perceive the difference. A
solution could be to group the interactions to one button or remove one of them.

See vuejs/vitepress#3806

bdon added 3 commits January 6, 2025 16:47
* Make cost calculator page elements have accessible labels and rework visually.
Replace twitter link with bluesky link.
@bdon bdon changed the title Make cost calculator page accessible and rework visually. accessibility improvements Jan 6, 2025
@bdon bdon merged commit 2c74c37 into main Jan 6, 2025
1 check passed
@bdon bdon deleted the accessibility branch January 6, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant