This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
Fix proto dependency conflicts for prysm, issues building go_path. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you elaborate on the original issue? |
|
Specifically wondering what prompted this as several members of the team use |
|
Please see prysmaticlabs/prysm#4024 |
nisdas
suggested changes
Nov 18, 2019
| ], | ||
| patch_args = ["-p1"], | ||
| patches = [ | ||
| # TODO remove patch once https://github.com/bazelbuild/rules_go/pull/2283 is merged |
There was a problem hiding this comment.
Lets block this until this PR is merged in rules_go , other than that looks good to me
Remove `#gazelle:proto disable-global` directive causing proto clashes with well known types. Add `#gazelle:proto disable` directive for trezor proto files, and fix trezor proto dep clash for WKT. Add a cc_library rule for libsecp256k1, srcs and hdrs filegroups. Secp256k1 target to use the filegroups for libsecp256k1 files. Resolve go_path build clash for libsecp256k1 `.h` files with the same basename. Update core rules in workspace, inc go_path fix patch.
|
Now using native cc_library rule, not trying to load anything. |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Mar 10, 2020
Fix protobuf dependency conflicts for well known types. (as described in https://github.com/bazelbuild/rules_go/blob/master/proto/core.rst#avoiding-conflicts) Add rules_go go_path patch to fix clashes for deep cgo c files. (See bazel-contrib/rules_go#2283) Add bazel-go-ethereum fixes as a patch. (See prysmaticlabs/bazel-go-ethereum#13) Apply suggested changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes that allow this to be part of a
go_pathrule (see commit msg).Aim is to for prysm and dependencies to be exported into a GOPATH-style directory structure suitable for
go build(e.g. for custom go-build used for fuzzing).