Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use correct variable for Git commit SHA in push workflow #212

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ArnaudLier
Copy link
Contributor

Replace the non-existent GIT_COMMIT variable with the correct GITHUB_SHA. GIT_COMMIT seems to be a name used by the Git plugin for Jenkins and has been introduced in this commit by schrej.

Replace the non-existent `GIT_COMMIT` variable with the correct `GITHUB_SHA`. `GIT_COMMIT` seems to be a name used by the Git plugin for Jenkins and has been introduced in [this commit](pterodactyl@7a456dc) by schrej.
Copy link

@rowansc1 rowansc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. What about you @matthewpi?

@danny6167
Copy link
Member

danny6167 commented Jan 17, 2025

Looks good here

daniel@DESKTOP-J3JHOJP:~/wingver$ ./wings version
wings vdev-58e7975
Copyright © 2018 - 2025 Dane Everitt & Contributors

@danny6167 danny6167 self-requested a review January 17, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants