-
Notifications
You must be signed in to change notification settings - Fork 428
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #163 from ptmt/merge-0.44.0
Merge with upstream / React Native 0.44.0
- Loading branch information
Showing
2,764 changed files
with
184,131 additions
and
83,663 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,3 +9,6 @@ end_of_line = lf | |
| insert_final_newline = true | ||
| indent_style = space | ||
| indent_size = 2 | ||
|
|
||
| [*.gradle] | ||
| indent_size = 4 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,4 @@ | |
| **/staticBundle.js | ||
| **/main.js | ||
| Libraries/vendor/**/* | ||
| packager/src/worker-farm/**/* | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,36 @@ | ||
| Hey there and thank you for using React Native! | ||
| Please read the following carefully before opening a new issue. | ||
| Your issue may be closed if it does not provide the information required by this template. | ||
|
|
||
| React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly. | ||
| We use GitHub Issues exclusively for tracking bugs in React Native. | ||
|
|
||
| Do the checklist before filing an issue: | ||
| - If you have a question, ask on Stack Overflow: http://stackoverflow.com/questions/tagged/react-native | ||
| - If you have a feature request, post it on Canny: https://react-native.canny.io/feature-requests | ||
|
|
||
| - [ ] Is this something you can **debug and fix**? Send a pull request! Bug fixes and documentation fixes are welcome. | ||
| - [ ] Have a usage question? Ask your question on [StackOverflow](http://stackoverflow.com/questions/tagged/react-native). We use StackOverflow for usage question and GitHub for bugs. | ||
| - [ ] Have an idea for a feature? Post the feature request on [Product Pains](https://productpains.com/product/react-native/). It has a voting system to surface the important issues. GitHub issues should only be used for bugs. | ||
| Make sure your issue reproduces on master. Your issue may already have been fixed! | ||
| If your issue is present in master and in the stable release, try to reproduce your bug on https://snack.expo.io/ | ||
| If you can't reproduce the bug on Snack, provide a sample project. | ||
| At the very least, provide an example of your code. | ||
|
|
||
| --- Delete everything above this line --- | ||
|
|
||
| None of the above, create a bug report | ||
| ------------------------------------------------------------------ | ||
| ### Description | ||
|
|
||
| Make sure to add **all the information needed to understand the bug** so that someone can help. If the info is missing we'll add the 'Needs more information' label and close the issue until there is enough information. | ||
| Explain what you did, what you expected to happen, and what actually happens. | ||
|
|
||
| - [ ] Provide a **minimal code snippet** / [rnplay](https://rnplay.org/) example that reproduces the bug. | ||
| - [ ] Provide **screenshots** where appropriate | ||
| - [ ] What's the **version** of React Native you're using? | ||
| - [ ] Does this occur on iOS, Android or both? | ||
| - [ ] Are you using Mac, Linux or Windows? | ||
| ### Reproduction Steps and Sample Code | ||
|
|
||
| List all the steps required to reproduce the issue you're reporting. These steps should be clear and concise. | ||
|
|
||
| ***An example of your code is REQUIRED*** | ||
|
|
||
|
|
||
| ### Solution | ||
|
|
||
| What needs to be done to address this issue? Ideally, provide a pull request with a fix. | ||
|
|
||
| ### Additional Information | ||
|
|
||
| * React Native version: [FILL THIS OUT: Be specific, filling out "latest" here is not enough.] | ||
| * Platform: [FILL THIS OUT: iOS, Android, or both?] | ||
| * Development Operating System: [FILL THIS OUT: Are you developing on MacOS, Linux, or Windows?] | ||
| * Dev tools: [FILL THIS OUT: Xcode or Android Studio version, iOS or Android SDK version, if applicable] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,32 @@ | ||
| Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: | ||
| Thanks for submitting a PR! Please read these instructions carefully: | ||
|
|
||
| > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** | ||
| - [ ] Explain the **motivation** for making this change. | ||
| - [ ] Provide a **test plan** demonstrating that the code is solid. | ||
| - [ ] Match the **code formatting** of the rest of the codebase. | ||
| - [ ] Target the `master` branch, NOT a "stable" branch. | ||
|
|
||
| Explain the **motivation** for making this change. What existing problem does the pull request solve? | ||
| ## Motivation (required) | ||
|
|
||
| Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. | ||
| What existing problem does the pull request solve? | ||
|
|
||
| **Test plan (required)** | ||
| ## Test Plan (required) | ||
|
|
||
| Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. | ||
| A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. | ||
|
|
||
| Make sure tests pass on both Travis and Circle CI. | ||
| If you have added code that should be tested, add tests. | ||
|
|
||
| **Code formatting** | ||
| ## Next Steps | ||
|
|
||
| Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). | ||
| Sign the [CLA][2], if you haven't already. | ||
|
|
||
| For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests). | ||
| Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. | ||
|
|
||
| Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. | ||
|
|
||
| For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines. | ||
|
|
||
| [1]: https://medium.com/@martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9 | ||
| [2]: https://code.facebook.com/cla | ||
| [3]: https://travis-ci.org/facebook/react-native | ||
| [4]: http://circleci.com/gh/facebook/react-native | ||
| [5]: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| # rnpm | ||
| /local-cli/rnpm | ||
| /local-cli/server/middleware/heapCapture/bundle.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,37 @@ | ||
| language: objective-c | ||
|
|
||
| matrix: | ||
| include: | ||
| - os: osx | ||
| osx_image: xcode8.2 | ||
| env: | ||
| - TEST_TYPE=objc | ||
| - SDK_TO_TEST='macosx10.12' | ||
| - os: osx | ||
| osx_image: xcode7.3 | ||
| env: | ||
| - TEST_TYPE=objc | ||
| - SDK_TO_TEST='macosx10.11' | ||
| - os: osx | ||
| osx_image: xcode6.4 | ||
| env: | ||
| - TEST_TYPE=objc | ||
| - SDK_TO_TEST='macosx10.10' | ||
| - os: osx | ||
| osx_image: xcode6.4 | ||
| env: | ||
| - TEST_TYPE=objc | ||
| - SDK_TO_TEST='macosx10.9' | ||
| - os: osx | ||
| env: TEST_TYPE=js | ||
| osx_image: xcode8.2 | ||
|
|
||
| install: | ||
| - mkdir -p /Users/travis/build/facebook/.nvm | ||
| - export NVM_DIR="/Users/travis/build/facebook/.nvm" | ||
| - brew install nvm | ||
| - source $(brew --prefix nvm)/nvm.sh | ||
| # TODO npm 2 started stalling on Travis, t11852928 | ||
|
|
||
| # Use node 6 because that is what runs on land-blocking tests | ||
| - nvm install 6 | ||
| - rm -Rf "${TMPDIR}/jest_preprocess_cache" | ||
| - npm config set spin=false | ||
| - npm config set progress=false | ||
| - travis_wait npm install | ||
| - node --version | ||
| - npm --version | ||
| - wget https://github.com/yarnpkg/yarn/releases/download/v0.16.0/yarn-0.16.0.js | ||
| - export yarn="node $(pwd)/yarn-0.16.0.js" | ||
| - $yarn install | ||
|
|
||
| script: | ||
| - if [[ "$TEST_TYPE" = objc ]]; then travis_retry travis_wait ./scripts/objc-test.sh; fi | ||
| - if [[ "$TEST_TYPE" = objc-macos ]]; then travis_retry travis_wait ./scripts/objc-test-macos.sh test; fi | ||
| - if [[ "$TEST_TYPE" = e2e-objc ]]; then node ./scripts/run-ci-e2e-tests.js --macos --js --retries 3; fi | ||
| - if [[ "$TEST_TYPE" = js ]]; then npm run flow check; fi | ||
| - if [[ "$TEST_TYPE" = js ]]; then npm test -- --maxWorkers=1; fi | ||
| - if [[ ( "$TEST_TYPE" = podspecs ) && ( "$TRAVIS_PULL_REQUEST" = "false" ) ]]; then gem install cocoapods && ./scripts/process-podspecs.sh; fi | ||
|
|
||
|
|
||
| matrix: | ||
| - fast_finish: true # Fail the whole build as soon as one test type fails. Should help with Travis capacity issues (very long queues). | ||
|
|
||
| # The order of these tests says which are more likely to run first and fail the whole build fast. | ||
| env: | ||
| - TEST_TYPE=objc-macos | ||
| - TEST_TYPE=podspecs | ||
| - TEST_TYPE=e2e-objc | ||
|
|
||
| branches: | ||
| only: | ||
| - master | ||
| - /^.*-stable$/ | ||
| - /^merge-.*$/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.