Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noissue]: Bump django-storages[boto3] from 1.14.3 to 1.14.4 #5553

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 9, 2024

Bumps django-storages[boto3] from 1.14.3 to 1.14.4.

Changelog

Sourced from django-storages[boto3]'s changelog.

1.14.4 (2024-07-09)


S3

  • Pull AWS_SESSION_TOKEN from the environment ([#1399](https://github.com/jschneier/django-storages/issues/1399)_)
  • Fix newline handling for text mode files ([#1381](https://github.com/jschneier/django-storages/issues/1381)_)
  • Do not sign URLs when querystring_auth=False e.g public buckets or static files ([#1402](https://github.com/jschneier/django-storages/issues/1402)_)
  • Cache CloudFront Signers ([#1417](https://github.com/jschneier/django-storages/issues/1417)_)

Azure

  • Fix collectstatic --clear ([#1403](https://github.com/jschneier/django-storages/issues/1403)_)
  • Add mode kwarg to .url() to support creation of signed URLs for upload ([#1414](https://github.com/jschneier/django-storages/issues/1414)_)
  • Fix fetching user delegation key when custom domain is enabled ([#1418](https://github.com/jschneier/django-storages/issues/1418)_)

SFTP

  • Add implementations of get_(modified|accessed)_time ([#1347](https://github.com/jschneier/django-storages/issues/1347)_)

Dropbox

  • Add support for Python 3.12 ([#1421](https://github.com/jschneier/django-storages/issues/1421)_)

FTP

  • Conform to BaseStorage interface ([#1423](https://github.com/jschneier/django-storages/issues/1423)_)
  • Add FTP_ALLOW_OVERWRITE setting ([#1424](https://github.com/jschneier/django-storages/issues/1424)_)

.. _#1399: jschneier/django-storages#1399 .. _#1381: jschneier/django-storages#1381 .. _#1402: jschneier/django-storages#1402 .. _#1403: jschneier/django-storages#1403 .. _#1414: jschneier/django-storages#1414 .. _#1417: jschneier/django-storages#1417 .. _#1418: jschneier/django-storages#1418 .. _#1347: jschneier/django-storages#1347 .. _#1421: jschneier/django-storages#1421 .. _#1423: jschneier/django-storages#1423 .. _#1424: jschneier/django-storages#1424

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the Dependencies Pull requests that update a dependency file label Jul 9, 2024
mdellweg
mdellweg previously approved these changes Jul 16, 2024
@mdellweg mdellweg enabled auto-merge (rebase) July 16, 2024 13:36
@dependabot dependabot bot force-pushed the dependabot/pip/django-storages-boto3--1.14.4 branch from 3b87e40 to adb0205 Compare July 17, 2024 13:06
@ggainey ggainey closed this Jul 17, 2024
auto-merge was automatically disabled July 17, 2024 17:28

Pull request was closed

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 17, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@ggainey ggainey reopened this Jul 17, 2024
@mdellweg
Copy link
Member

@dependabot rebase

Bumps [django-storages[boto3]](https://github.com/jschneier/django-storages) from 1.14.3 to 1.14.4.
- [Changelog](https://github.com/jschneier/django-storages/blob/master/CHANGELOG.rst)
- [Commits](jschneier/django-storages@1.14.3...1.14.4)

---
updated-dependencies:
- dependency-name: django-storages[boto3]
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/django-storages-boto3--1.14.4 branch from adb0205 to 3f6fc26 Compare July 18, 2024 14:26
@mdellweg
Copy link
Member

So this updating the boto stuff, and failing the S3 test is sufficient coincidence to me indicating that something broke. Looking at the changelog, is there anything we need from this update, or can we postpone investigating this?

@ggainey
Copy link
Contributor

ggainey commented Jul 18, 2024

So this updating the boto stuff, and failing the S3 test is sufficient coincidence to me indicating that something broke. Looking at the changelog, is there anything we need from this update, or can we postpone investigating this?

I didn't see anything in the commit-msgs that was a must-have, and yeah, I am also concerned that "it breaks something". It might just be the tests that need to be fixed, but I really don't know. I'm ok with holding off until we free up some cycles to figure out what's going on.

@mdellweg
Copy link
Member

This is what's going on:
jschneier/django-storages#1430

@mdellweg
Copy link
Member

Let's not pick up that version. It is obviously broken.

@mdellweg mdellweg closed this Jul 18, 2024
@dependabot dependabot bot deleted the dependabot/pip/django-storages-boto3--1.14.4 branch July 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants