Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange Contributing pages + add gitpod info to contributing area #216

Merged
merged 13 commits into from
Mar 29, 2023

Conversation

reshamas
Copy link
Contributor

@reshamas reshamas commented Mar 26, 2023

Towards #178

  • move Event Info (PR section) into "Contributing" section
  • add Gitpod info to "Contributing" section

📚 Documentation preview en 📚: https://pymc-data-umbrella--216.org.readthedocs.build/en/216/

📚 Documentation preview es 📚: https://pymc-data-umbrella-es--216.org.readthedocs.build/es/216/

📚 Documentation preview pt 📚: https://pymc-data-umbrella-pt--216.org.readthedocs.build/pt/216/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being duplicated or moved? Reviewing from my phone and not sure what is going on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OriolAbril
I am trying to move the "environment setup" section from "Event info" to "Contribute".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OriolAbril
Perhaps I should not have "moved" them and instead changed how I "referenced" them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving is fine, they look moved now in yhe PR changes. The only step missing is adding the redirects so links we have shared to their current location continue working after we merge this PR.

As we use ref type cross references, all internal links should continue to work without any extra work needed on the files that reference the updated files.

@reshamas
Copy link
Contributor Author

@OriolAbril
Hopefully I did not make too much of a mess. The structure is what I am looking for.

I hope moving files around does not interfere with the translations. Not sure what the impact is.

@reshamas reshamas requested a review from OriolAbril March 26, 2023 17:14
conf.py Outdated Show resolved Hide resolved
conf.py Outdated
@@ -59,7 +59,7 @@
"webinars/contributing_to_pymc/index.md": "about/contributing_to_pymc/index.md",
"webinars/intro_to_array_operations/index.md": "about/intro_to_array_operations/index.md",
"webinars/probabilistic_programming_with_pymc/index.md": "about/probabilistic_programming_with_pymc/index.md",
"sprint/docstring_tutorial.md": "sprint/tutorials/docstring_tutorial.md",
"sprint/docstring_tutorial.md": "contributing/tutorials/docstring_tutorial.md",
"index.md": "2023-03_sprint/index.md",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"index.md": "2023-03_sprint/index.md",
"index.md": "2023-03_sprint/index.md",
"sprint/tutorials/docstring_tutorial.md": "contributing/tutorials/docstring_tutorial.md",

And this needs to be added, also for env setup and pr step by step

@OriolAbril
Copy link
Member

I am not sure about effect to translations. If it doesn't catch the rename and loses the info I'll rename the po files to keep that info

@reshamas reshamas changed the title add gitpod info to contributing area Rearrange Contributing pages + add gitpod info to contributing area Mar 28, 2023
@reshamas reshamas requested a review from OriolAbril March 28, 2023 12:12
@reshamas reshamas merged commit 91f2cfc into pymc-devs:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants