-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange Contributing pages + add gitpod info to contributing area #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this being duplicated or moved? Reviewing from my phone and not sure what is going on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OriolAbril
I am trying to move the "environment setup" section from "Event info" to "Contribute".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OriolAbril
Perhaps I should not have "moved" them and instead changed how I "referenced" them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving is fine, they look moved now in yhe PR changes. The only step missing is adding the redirects so links we have shared to their current location continue working after we merge this PR.
As we use ref
type cross references, all internal links should continue to work without any extra work needed on the files that reference the updated files.
@OriolAbril I hope moving files around does not interfere with the translations. Not sure what the impact is. |
conf.py
Outdated
@@ -59,7 +59,7 @@ | |||
"webinars/contributing_to_pymc/index.md": "about/contributing_to_pymc/index.md", | |||
"webinars/intro_to_array_operations/index.md": "about/intro_to_array_operations/index.md", | |||
"webinars/probabilistic_programming_with_pymc/index.md": "about/probabilistic_programming_with_pymc/index.md", | |||
"sprint/docstring_tutorial.md": "sprint/tutorials/docstring_tutorial.md", | |||
"sprint/docstring_tutorial.md": "contributing/tutorials/docstring_tutorial.md", | |||
"index.md": "2023-03_sprint/index.md", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"index.md": "2023-03_sprint/index.md", | |
"index.md": "2023-03_sprint/index.md", | |
"sprint/tutorials/docstring_tutorial.md": "contributing/tutorials/docstring_tutorial.md", |
And this needs to be added, also for env setup and pr step by step
I am not sure about effect to translations. If it doesn't catch the rename and loses the info I'll rename the po files to keep that info |
Co-authored-by: Oriol Abril-Pla <[email protected]>
Towards #178
📚 Documentation preview en 📚: https://pymc-data-umbrella--216.org.readthedocs.build/en/216/
📚 Documentation preview es 📚: https://pymc-data-umbrella-es--216.org.readthedocs.build/es/216/
📚 Documentation preview pt 📚: https://pymc-data-umbrella-pt--216.org.readthedocs.build/pt/216/