Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix to a missing in the inline script metadata doc. #1777

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor fix to a missing in the inline script metadata doc. #1777

wants to merge 1 commit into from
+1 −1

Conversation

Julian
Copy link
Contributor

@Julian Julian commented Jan 7, 2025 •
edited by github-actions bot
Loading

@echoix
Copy link

echoix commented Jan 9, 2025 •
edited
Loading

I'm just an outsider here, (but review PR for other projects I work on), but I think this is fine, and the meaning of tool table is already used around, so definitely better with this PR. Perhaps have a second read at the title of the PR ("Minor fix to a missing WHAT? in the inline ..."), and it's good to go!

@Julian
Copy link
Contributor Author

Julian commented Jan 9, 2025

The title was intentional :) always room for a bit of fun. Thanks for the review.

@echoix
Copy link

echoix commented Jan 9, 2025

The title was intentional :) always room for a bit of fun. Thanks for the review.

Haha, I fell right into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

@sinoroc sinoroc sinoroc approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Julian @echoix @sinoroc