This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 101
Proud Puffins - submitting final PR that fell through the cracks. #138
Open
babarrett
wants to merge
15
commits into
python-discord:main
Choose a base branch
from
babarrett:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove '\\n' s and lowercase entire bio - Remove swear words, other web links for privacy concerns - Remove user_gen.py, raw.json from tools/
- Remove name mentions
- likedyou and youliked were returning UserVote objects which made Null Qset when intersected - Made them return values_list of users and intersected them to actually give matches - Passed them into a matches list which gets users based on pk's of the intersected list
Add requirements
- Add alternative way to install the application - Add instructions to use the app.
Doumentation part 1
Add a note about lint error
resize headings of Learning materials and normalize.css to match rest of them
ghost
added
the
needs 2 approvals
label
Sep 12, 2020
babarrett
changed the title
Prwoud Puffins - submitting final PR that fell through the cracks.
Proud Puffins - submitting final PR that fell through the cracks.
Sep 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these changes were done before the deadline.
Some improve the Docs / how to install.
Some are code fixes that are needed to make the project work.
All files are time-stamped before the deadline.