Skip to content

Commit

Permalink
Merge pull request #3173 from A5rocks/codecov-not-strict
Browse files Browse the repository at this point in the history
Stop failing CI upon codecov error 503
  • Loading branch information
jakkdl authored Dec 30, 2024
2 parents 3de7996 + 8e2bfa9 commit d2bb9d8
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,7 @@ jobs:
# multiple flags is marked as an error in codecov UI, but is actually fine
# https://github.com/codecov/feedback/issues/567
flags: Windows,${{ matrix.python }}
# this option cannot be set in .codecov.yml
fail_ci_if_error: true
fail_ci_if_error: false # change to true when using codecov action v5

Ubuntu:
name: 'Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})'
Expand Down Expand Up @@ -288,7 +287,7 @@ jobs:
directory: empty
name: Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})
flags: Ubuntu,${{ matrix.python }}
fail_ci_if_error: true
fail_ci_if_error: false
macOS:
name: 'macOS (${{ matrix.python }})'
Expand Down Expand Up @@ -330,7 +329,7 @@ jobs:
directory: empty
name: macOS (${{ matrix.python }})
flags: macOS,${{ matrix.python }}
fail_ci_if_error: true
fail_ci_if_error: false

# run CI on a musl linux
Alpine:
Expand Down Expand Up @@ -366,7 +365,7 @@ jobs:
directory: empty
name: Alpine
flags: Alpine,${{ steps.get-version.outputs.version }}
fail_ci_if_error: true
fail_ci_if_error: false

Cython:
name: "Cython"
Expand Down Expand Up @@ -426,7 +425,7 @@ jobs:
with:
name: Cython
flags: Cython,${{ steps.get-version.outputs.version }}
fail_ci_if_error: true
fail_ci_if_error: false

# https://github.com/marketplace/actions/alls-green#why
check: # This job does nothing and is only used for the branch protection
Expand Down

0 comments on commit d2bb9d8

Please sign in to comment.