-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127146: Emscripten Include compiler version in _PYTHON_HOST_PLATFORM #127992
Conversation
…PLATFORM `test_sysconfigdata_json` is failing. This doesn't entirely fix it but it moves the failure later -- before it doesn't even find the sysconfigdata file because of a descrepancy between what `uname()` returns and what `configure.ac` sets `_PYTHON_HOST_PLATFORM` to. After, there are some small differences.
To actually fix the test, we could either skip the check for prefix-related keys or regenerate the sysconfigdata with the cli after the build is completed. The first change would look like: @@ -651,9 +652,13 @@ def test_sysconfigdata_json(self):
system_config_vars = get_config_vars()
# Ignore keys in the check
- for key in ('projectbase', 'srcdir'):
- json_config_vars.pop(key)
- system_config_vars.pop(key)
+ ignore_keys = ('projectbase', 'srcdir')
+ if is_emscripten:
+ ignore_keys += ("exec_prefix", "installed_base", "installed_platbase", "prefix", "platbase", "userbase")
+
+ for key in ignore_keys:
+ json_config_vars.pop(key, None)
+ system_config_vars.pop(key, None)
self.assertEqual(system_config_vars, json_config_vars) @freakboy3742 maybe we could do this for android and ios too? |
Co-authored-by: Kleis Auke Wolthuizen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself makes sense; one note inline about formatting, and it looks like CI is failing because autoreconf hasn't been run since your most recent update.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
Thanks for making the requested changes! @freakboy3742: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those fixes - looks great!
|
I can't see why this change would have any impact on Windows being unable to start multiprocessing... |
Presumably a flake =) |
…PLATFORM (python#127992) Modifies _PYTHON_HOST_PLATFORM to include the compiler version under Emscripten. The Emscripten compiler version is the platform version compatibility identifier.
test_sysconfigdata_json
is failing. This doesn't entirely fix it but it moves the failure later -- before this change it doesn't even find the sysconfigdata file because of a descrepancy between whatuname()
returns and whatconfigure.ac
sets_PYTHON_HOST_PLATFORM
to. After, there are some small differences.