Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exp2 for mx scaling #1530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use exp2 for mx scaling #1530

wants to merge 1 commit into from

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Jan 9, 2025

Stacked PRs:


Use exp2 for mx scaling

Copy link

pytorch-bot bot commented Jan 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1530

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures

As of commit 6238167 with merge base 8259a38 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

drisspg added a commit that referenced this pull request Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2025
drisspg added a commit that referenced this pull request Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg added a commit that referenced this pull request Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
drisspg added a commit that referenced this pull request Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
@drisspg drisspg requested a review from vkuzo January 9, 2025 17:35
drisspg added a commit that referenced this pull request Jan 9, 2025
stack-info: PR: #1530, branch: drisspg/stack/26
torch.full(max_abs.size(), 2.0, device=scale_e8m0_biased.device),
scale_e8m0_unbiased,
)
scale_fp = torch.exp2(scale_e8m0_unbiased).to(torch.float32)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about torch.exp2

@vkuzo
Copy link
Contributor

vkuzo commented Jan 9, 2025

should ensure CI is green though

stack-info: PR: #1530, branch: drisspg/stack/26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants