Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispersive shift restless #955

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Dispersive shift restless #955

wants to merge 10 commits into from

Conversation

Jacfomg
Copy link
Contributor

@Jacfomg Jacfomg commented Jul 31, 2024

Draft for the Dispersive shift restless. It can help to track the resonator behavior with restless operation of the device.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@Jacfomg Jacfomg removed the request for review from Edoardo-Pedicillo July 31, 2024 12:23
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 37.66234% with 48 lines in your changes missing coverage. Please review.

Project coverage is 97.02%. Comparing base (f8c04db) to head (dfeefd5).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
- Coverage   97.52%   97.02%   -0.51%     
==========================================
  Files         118      119       +1     
  Lines        9056     9133      +77     
==========================================
+ Hits         8832     8861      +29     
- Misses        224      272      +48     
Flag Coverage Δ
unittests 97.02% <37.66%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/protocols/__init__.py 100.00% <100.00%> (ø)
src/qibocal/protocols/dispersive_shift_restless.py 36.84% <36.84%> (ø)

... and 2 files with indirect coverage changes

@alecandido
Copy link
Member

Couldn't it be an option, instead of another routine?

@Jacfomg
Copy link
Contributor Author

Jacfomg commented Jul 31, 2024

Couldn't it be an option, instead of another routine?

Not sure, can't run in the QPU it gets free then I can see if they are usefull and I can merge them with existant routines if so

@Jacfomg Jacfomg marked this pull request as ready for review August 7, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants