Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up workflow names (steps / jobs) #1149

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Conversation

lsegal
Copy link
Member

@lsegal lsegal commented Nov 18, 2024

No description provided.

@lsegal lsegal self-assigned this Nov 18, 2024
@lsegal lsegal requested a review from brynary November 18, 2024 22:37
Copy link
Member

@brynary brynary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

BTW, I think we can remove the use of the cancel-workflow-action in favor the the native GHA "concurrency" feature: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

I don't think that feature existed when we added the styfle/cancel-workflow-action steps everywhere

@lsegal lsegal merged commit 30512f6 into main Nov 18, 2024
13 checks passed
@lsegal lsegal deleted the ls/cleanup-workflow-names branch November 18, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants