Ignore import statements (Java) and using directives (C#) when calculating duplication
#1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Can we please get a test for this which fails before this patch and passes after? |
noahd1
force-pushed
the
nd-duplication-filters
branch
from
28ab15e to
4ed51ce
Compare
|
@brynary Updated this PR with 1 commit that introduces a failing test and 1 commit that fixes it. |
brynary
approved these changes
Jan 10, 2025
| @@ -0,0 +1,4 @@ | |||
| [0/3] [..]Analyzing all targets... [..]s | |||
| [1/3] [..]Checking structure of 4 files... [..]s | |||
| [2/3] [..]Looking for duplication across 4 files... [..]s | |||
There was a problem hiding this comment.
I would delete this file, because the snapshot testing framework will not match against stderr if there is no file. This will make the test less brittle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignores
importstatements (in Java) andusingdirectives (in C#) when calculating duplication.