Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters to customize keep_firing_for Prometheus rule #23

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Add parameters to customize keep_firing_for Prometheus rule #23

merged 1 commit into from
Jan 5, 2024

Conversation

vmercierfr
Copy link
Contributor

Objective

Add defaultKeepFiringFor and keepFiringFor parameters to Helm chart and configure keep_firing_for attribute.

Why

Users may need to customize the keep_firing_for Prometheus rule parameter for some alerts.

At Qonto, we need this parameter to keep alerts open during Pod rescheduling.

How

  • Add defaultKeepFiringFor and keepFiringFor Helm parameters

Release plan

  • Merge this PR

ortizjavier
ortizjavier approved these changes Jan 4, 2024
View reviewed changes
Copy link

@ortizjavier ortizjavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmercierfr vmercierfr force-pushed the add-keep-firing-for branch from 50332a6 to 4adf2c7 Compare January 5, 2024 10:14
@vmercierfr vmercierfr merged commit 4a3496a into main Jan 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ortizjavier ortizjavier ortizjavier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmercierfr @ortizjavier