Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate metrics by labels #9

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Aggregate metrics by labels #9

merged 2 commits into from
Nov 21, 2023

Conversation

vmercierfr
Copy link
Contributor

Objective

Aggregate metrics by labels

Why

  • Alert rules are not aggregated by dbidentifier. So when multiple exporters are deployed or scheduled in Kubernetes environment, it may prevent alerts.
  • aws_account_id or aws_region labels are not matched, same dbidentifier is multiple accounts could lead to incorrect alerts

How

  • Rewrite queries to use max by (labels) (metrics) style
  • Add aws_account_id and aws_region label to support multiple-region

Release plan

  • Merge this PR

@vmercierfr vmercierfr added the bug Something isn't working label Nov 21, 2023
@vmercierfr
Copy link
Contributor Author

#sre

@vmercierfr vmercierfr added this to the 0.1 milestone Nov 21, 2023
@vmercierfr vmercierfr merged commit d5f4ff8 into main Nov 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants