Skip to content

Commit

Permalink
Merge pull request #285 from qonto/drop-node-16
Browse files Browse the repository at this point in the history
feat: drop node v16
  • Loading branch information
vscav authored Nov 14, 2023
2 parents 8f922a1 + fa6636c commit c5d8725
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
name: Install pnpm
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x

- name: Lint
run: pnpm lint
Expand All @@ -45,7 +45,7 @@ jobs:
name: Install pnpm
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x
args: "--no-lockfile"

- name: Run Tests
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:
name: Install pnpm
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x

- name: Run Tests
run: pnpm try:ember ${{ matrix.try-scenario }}
Expand All @@ -107,7 +107,7 @@ jobs:
uses: wyvox/action-setup-pnpm@v3
with:
pnpm-version: 8.5.1
node-version: 16.x
node-version: 18.x
args: "--frozen-lockfile"
- name: Update TS version on addon package
run: pnpm add -D ${{ matrix.typescript-scenario }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Render [lottie](https://github.com/airbnb/lottie-web) after effects animations i

- Ember.js v3.28 or above
- Ember CLI v3.28 or above
- Node.js v14 or above
- Node.js v18 or above
- TypeScript v5 or above

## Installation
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"release-it": "^15.11.0"
},
"engines": {
"node": "14.* || 16.* || >= 18"
"node": ">= 18"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
Expand Down
2 changes: 1 addition & 1 deletion test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"webpack": "^5.89.0"
},
"engines": {
"node": "14.* || 16.* || >= 18"
"node": ">= 18"
},
"ember": {
"edition": "octane"
Expand Down

0 comments on commit c5d8725

Please sign in to comment.