[4419][IMP] account_invoice_report_hls #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanda999
changed the title
kanda999
force-pushed
the
12.0-2-imp-account_invoice_report_hls
branch
from
de48c8a to
75153e9
Compare
kanda999
force-pushed
the
12.0-2-imp-account_invoice_report_hls
branch
from
75153e9 to
9f94a16
Compare
yostashiro
reviewed
May 30, 2024
Comment on lines
11
to
15
| def render_qweb_pdf(self, res_id=None, data=None): | ||
| if self.report_name == "account_invoice_report_hls.invoice_delivery": | ||
| invoices = self.env["account.invoice"].browse(res_id) | ||
| invoices._create_invoice_delivery_report() | ||
| return super(IrActionsReport, self).render_qweb_pdf(res_id, data) |
There was a problem hiding this comment.
To be a bit safer.
Suggested change
| def render_qweb_pdf(self, res_id=None, data=None): | |
| if self.report_name == "account_invoice_report_hls.invoice_delivery": | |
| invoices = self.env["account.invoice"].browse(res_id) | |
| invoices._create_invoice_delivery_report() | |
| return super(IrActionsReport, self).render_qweb_pdf(res_id, data) | |
| def render_qweb_pdf(self, res_ids=None, data=None): | |
| if self.report_name == "account_invoice_report_hls.invoice_delivery": | |
| if not res_ids: | |
| res_ids = self.env.context.get("active_ids") | |
| invoices = self.env["account.invoice"].browse(res_ids) | |
| invoices._create_invoice_delivery_report() | |
| return super(IrActionsReport, self).render_qweb_pdf(res_ids, data) |
| line_ids = fields.One2many("invoice.delivery.report.line", inverse_name="report_id") | ||
| report_line_ids = fields.One2many( | ||
| "invoice.delivery.report.line", inverse_name="report_id" | ||
| ) | ||
|
|
||
| @api.model |
There was a problem hiding this comment.
Suggested change
| @api.model | |
| @api.multi |
|
|
||
|
|
||
| class InvoiceDeliveryReportLine(models.TransientModel): | ||
| _name = "invoice.delivery.report.line" | ||
| _order = "date_delivered" | ||
|
|
||
| report_id = fields.Many2one("invoice.delivery.report") | ||
| report_id = fields.Many2one("account.invoice") |
There was a problem hiding this comment.
Would make more sense to change the field name.
Suggested change
| report_id = fields.Many2one("account.invoice") | |
| invoice_id = fields.Many2one("account.invoice") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4332