-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3593][16.0][ADD] stock_lot_label_layout_custom #1
Conversation
@rinaldifirdaus Can you please review this first? I use the size as you suggested in task but it looks like not perfect. |
Current report will be like below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Printed the barcode, and the result now same with the sample. thanks lin!
_inherit = "lot.label.layout" | ||
|
||
print_format = fields.Selection( | ||
selection_add=[("A4", "A4")], ondelete={"A4": "cascade"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this option should be selected by default.
logging.info("Testing__________") | ||
logging.info(report_action) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these logging lines?
@@ -0,0 +1 @@ | |||
This module adds new custom report for lot label report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rinaldifirdaus Please update the description with background information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name suggestion; stock_lot_label_layout_custom
e82d629
to
59d31cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rinaldifirdaus Please regenarate README as it doesn't show the latest info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to reduce the node laddars by creating templates for some tag blocks (reduce the laddars as a general guideline). Not a blocking point.
@yostashiro san, i have updated the readme of this module. |
3593