Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3593][16.0][ADD] stock_lot_label_layout_custom #1

Merged
merged 9 commits into from
Nov 30, 2023

Conversation

AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as draft August 17, 2023 11:56
@AungKoKoLin1997
Copy link
Contributor Author

@rinaldifirdaus Can you please review this first? I use the size as you suggested in task but it looks like not perfect.

@rinaldifirdaus
Copy link
Contributor

Hi Lin, i've added 1 commit to adjust font size, padding of the barcode and add expiry date same with the default template.
this is still need to be improved, i compare the sample i created before with the current pdf result, seems like this module version having a letter spacing on it, also the left-border of the barcode is cutted.. could you please help to check this lin?
image

@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review August 18, 2023 09:07
@AungKoKoLin1997
Copy link
Contributor Author

Current report will be like below.
Lot-Serial - 11111 (2).pdf

Copy link
Contributor

@rinaldifirdaus rinaldifirdaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Printed the barcode, and the result now same with the sample. thanks lin!

_inherit = "lot.label.layout"

print_format = fields.Selection(
selection_add=[("A4", "A4")], ondelete={"A4": "cascade"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this option should be selected by default.

Comment on lines 17 to 18
logging.info("Testing__________")
logging.info(report_action)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these logging lines?

@@ -0,0 +1 @@
This module adds new custom report for lot label report.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rinaldifirdaus Please update the description with background information.

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name suggestion; stock_lot_label_layout_custom

@AungKoKoLin1997 AungKoKoLin1997 changed the title [3593][16.0][ADD] report_lot_custom_layout [3593][16.0][ADD] stock_lot_label_layout_custom Aug 22, 2023
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-report_lot_custom_layout branch from e82d629 to 59d31cb Compare October 10, 2023 03:33
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rinaldifirdaus Please regenarate README as it doesn't show the latest info.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to reduce the node laddars by creating templates for some tag blocks (reduce the laddars as a general guideline). Not a blocking point.

@rinaldifirdaus
Copy link
Contributor

@yostashiro san, i have updated the readme of this module.
as per discussed, we will not reduce the node laddars for now.
thank you

@yostashiro yostashiro merged commit bff469c into 16.0 Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants