[15.0][3917][IMP] purchase_order_supplier_phone: add functionals from sst #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
pushed a commit
that referenced
this pull request
Oct 25, 2023
AungKoKoLin1997
force-pushed
the
15.0-mig-purchase_order_supplier_phone
branch
3 times, most recently
from
b50df32 to
3b9af82
Compare
AungKoKoLin1997
requested review from
yostashiro,
kanda999,
rinaldifirdaus and
liuhehe1995
AungKoKoLin1997
pushed a commit
that referenced
this pull request
Oct 26, 2023
AungKoKoLin1997
force-pushed
the
15.0-mig-purchase_order_supplier_phone
branch
from
3b9af82 to
d0fbe56
Compare
AungKoKoLin1997
pushed a commit
that referenced
this pull request
Dec 4, 2023
kanda999
requested changes
Jan 22, 2024
| partner_id = ( | ||
| "partner_id" in vals and vals["partner_id"] or order.partner_id.id | ||
| ) | ||
| if self.is_default_partner(partner_id) and ( |
There was a problem hiding this comment.
is_default_partner depends on purchase_ext_sst module.
AungKoKoLin1997
force-pushed
the
15.0-mig-purchase_order_supplier_phone
branch
from
d0fbe56 to
d71fc44
Compare
yostashiro
reviewed
Jan 23, 2024
| @@ -7,7 +7,7 @@ | |||
| "website": "https://www.quartile.co", | |||
| "category": "Purchase", | |||
| "license": "LGPL-3", | |||
| "depends": ["purchase"], | |||
| "depends": ["purchase_ext_sst"], | |||
There was a problem hiding this comment.
To make the reason of dependency clear.
Suggested change
| "depends": ["purchase_ext_sst"], | |
| "depends": [ | |
| "purchase_ext_sst", # is_default_partner() | |
| ], |
AungKoKoLin1997
force-pushed
the
15.0-mig-purchase_order_supplier_phone
branch
from
d71fc44 to
d57b856
Compare
|
@AungKoKoLin1997 |
AungKoKoLin1997
force-pushed
the
15.0-mig-purchase_order_supplier_phone
branch
from
d57b856 to
09e9576
Compare
kanda999
force-pushed
the
15.0-mig-purchase_order_supplier_phone
branch
from
14a5840 to
4bb3d18
Compare
kanda999
approved these changes
Jan 23, 2024
kanda999
force-pushed
the
15.0-mig-purchase_order_supplier_phone
branch
from
4bb3d18 to
e5e4217
Compare
kanda999
force-pushed
the
15.0-mig-purchase_order_supplier_phone
branch
from
e5e4217 to
5e79909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3917