Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force snippet suggestions to the bottom of completions #609

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Do not force snippet suggestions to the bottom of completions #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ace61
Do not force snippet suggestions to the bottom of completions
juliasilge Nov 22, 2024
0c96434
Update changelog
juliasilge Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Provide F1 help at cursor in Positron (<https://github.com/quarto-dev/quarto/pull/599>)
- Expose new context keys for the language of a specific cell (<https://github.com/quarto-dev/quarto/pull/607>)
- No longer send all snippet suggestions to the bottom of the completion list (<https://github.com/quarto-dev/quarto/pull/609>).

## 1.117.0 (Release on 2024-11-07)

Expand Down
1 change: 0 additions & 1 deletion apps/vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,6 @@
"strings": "on"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little weirded out by the sheer volume of configuration options that quarto tweaks on its own. Maybe we should consider trimming this down in the future.

I find it quite hard to figure out "who" modified settings like these in the UI. The Settings UI reports "modified elsewhere" but you look in your user / project settings and can't see it being modified so you're left scratching your head about them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the sentiment, but I sort of trust that they were put there for a reason, and am left agreeing with the goal, but unable to come up with a plan to do it that I like.

},
"editor.quickSuggestionsDelay": 250,
"editor.snippetSuggestions": "bottom",
"editor.wordBasedSuggestions": "off",
"editor.suggestOnTriggerCharacters": true,
"editor.unicodeHighlight.ambiguousCharacters": false,
Expand Down