-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable any resolution for Unet #1029
Conversation
Codecov ReportAttention: Patch coverage is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I'm familiar enough with the details of the model to properly review this
): | ||
super().__init__() | ||
self.interpolate_mode = interpolation_mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit confusing to me to see both "interpolate" and "interpolation", maybe we can make these consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch! will fix it
Could this break compatibility with onnx export -> OpenCV inference? |
@JulienMaille thanks for looking into it! Right, initially, there was an issue with ONNX export, but nowadays ONNX export works with the |
@JulienMaille I just checked this; the minimum opset to export the model with |
What does this PR do?
scale_factor
withsize
argument in UnetDecodeBlock
to enable forward with any image resolution (not only divisible by 32)inference_mode
instead ofno_grad
in tests