-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor efficientnet-pytorch #1036
Conversation
Codecov ReportAttention: Patch coverage is
|
Thanks for moving it and removing dependency! What do you think re removing unnecessary code? I mean not all functions/methods are required, such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few things to remove and we can merge it
Thanks! |
pretrainedmodels is up next. This one is a bit more complicated because we have multiple models. Should we have a |
I prefer |
Supersedes #1018
EfficientNet-PyTorch doesn't have wheels on PyPI, and is no longer maintained. Let's vendor it and maintain it ourselves. This will make SMP easier to install.
This PR doesn't deprecate the non-timm EfficientNet implementation, but we can also do that if we want to. Let's wait until we have download statistics.
Will do the same thing with pretrainedmodels once this is merged.