-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Space
, Dimensions
, and GeneralDimensions
#360
Open
ytdHuang
wants to merge
43
commits into
main
Choose a base branch
from
dev/dimensions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytdHuang
commented
Jan 2, 2025
ytdHuang
changed the title
Introduce
Introduce Jan 7, 2025
Space
, Dimensions
, and CompoundDimensions
Space
, Dimensions
, and GeneralDimensions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
=======================================
Coverage 93.14% 93.15%
=======================================
Files 41 43 +2
Lines 2684 2775 +91
=======================================
+ Hits 2500 2585 +85
- Misses 184 190 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Thank you for contributing to
QuantumToolbox.jl
! Please make sure you have finished the following tasks before opening the PR.make test
.julia
formatted by running:make format
.docs/
folder) related to code changes were updated and able to build locally by running:make docs
.CHANGELOG.md
should be updated (regarding to the code changes) and built by running:make changelog
.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
Summary of this PR:
New structures:
AbstractSpace
Space
AbstractDimensions
Dimensions
GeneralDimensions
New field
dimensions
(originally calleddims
) forQobj
/QobjEvo
/TimeEvolutionProblem
/EigsolveResult
New property
dims
forQobj
/QobjEvo
/TimeEvolutionProblem
/EigsolveResult
New internal functions:
get_dimensions_to
get_dimensions_from
dimensions_to_dims
: transformAbstractDimensions
to integer-vector_get_dims_string
: to get thedims
string for printingChanged internal functions:
_check_dims
->_gen_dimensions
. This was the one to check the format of user specifieddims
, now it also checks the format and generates theDimensions
structure.check_dims
->check_dimensions
. This was the one to check if the twoQobj
have the samedims
, now it allows multiple inputQobj
and check whether allQobj.dimensions
are equal).Related issues or PRs
close #271
close #353