-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update parachain templates #297
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #297 +/- ##
==========================================
+ Coverage 75.11% 75.23% +0.12%
==========================================
Files 63 63
Lines 13842 13970 +128
Branches 13842 13970 +128
==========================================
+ Hits 10398 10511 +113
- Misses 2118 2120 +2
- Partials 1326 1339 +13
|
A reminder that removals should be deprecated, if not already |
In this case, we had a message from the start indicating that the Parity templates were deprecated: https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-cli/src/commands/new/parachain.rs#L132. I believe it would be reasonable to remove the deprecated template in the next release. |
Perfect! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an initial quick review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
┌ Pop CLI : Launch a local network
│
▲ ⚠️ The following binaries required to launch the network cannot be found locally:
│ > polkadot-parachain
│
◇ 📦 Would you like to source them automatically now? It may take some time...
│ > polkadot-parachain v1.13.0
│ Yes
│
⚙ ℹ️ Binaries will be cached at /Users/bruno/Library/Caches/pop
│
◇ 📦 Sourcing binaries...
│ ✅ polkadot-parachain
│
◐ 🚀 Launching local network...
thread 'main' panicked at /Users/bruno/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zombienet-orchestrator-0.2.7/src/lib.rs:390:36:
removal index (is 0) should be < len (is 0)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Steps to reproduce:
I generated the Polkadot SDK Parachain Template using pop new parachain
command, then ran pop build
then pop up parachain -f zombienet.toml
Steps to reproduceI generated the Parity substrate contracts node (v0.41.0) using |
It looks like you're using the |
I see... If you run |
Why are OZ templates being added to a PR for Parity? |
Apologies if this PR automatically requested a review before I made updates in the PR description and name. I’ve updated this PR to include a general update of the templates, with the OZ update as a minor version bump (I've created an issue to avoid having to do this update each time: #400). |
The PR title could be improved:
|
This PR introduces updates to the templates.
It introduces the new Parity parachain template: Polkadot SDK's Parachain Template, which replaces the existing contracts template as the default for Parity.
Closes
pop new
: Use latest paritytech templates #238It removes the Frontier Parachain template due to its lack of maintenance (no updates in the past 9 months).
For now, we will retain the Contracts Parachain, as it is actively maintained once again.
It updates the supported versions for the OpenZeppelin templates after its release.
The current logic for the supported versions needs to be updated: refactor(templates): replace
SupportedVersions
withUnSupportedVersions
#400[sc-1334]