build(release): update upload-artifact to v4 #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 75.12% 75.12%
=======================================
Files 63 63
Lines 13864 13864
Branches 13864 13864
=======================================
+ Hits 10415 10416 +1
+ Misses 2098 2097 -1
Partials 1351 1351 |
|
It seems the action fails after the change: https://github.com/r0gue-io/pop-cli/actions/runs/12666964995/job/35299364389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
upload-artifactaction needs to be updated to use v4 instead.Will test run our release workflow before asking for reviews.