build(release): update upload-artifact to v4 #833
clippy
109 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 109 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.84.0 (9fc6b4312 2025-01-07)
- cargo 1.84.0 (66221abde 2024-11-19)
- clippy 0.1.84 (9fc6b43126 2025-01-07)
Annotations
Check warning on line 13 in crates/pop-cli/src/commands/new/mod.rs
github-actions / clippy
missing documentation for a macro
warning: missing documentation for a macro
--> crates/pop-cli/src/commands/new/mod.rs:13:1
|
13 | macro_rules! enum_variants {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 57 in crates/pop-cli/src/main.rs
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> crates/pop-cli/src/main.rs:57:1
|
57 | pub struct Cli {
| ^^^^^^^^^^^^^^
Check warning on line 133 in crates/pop-cli/src/main.rs
github-actions / clippy
missing documentation for the crate
warning: missing documentation for the crate
--> crates/pop-cli/src/main.rs:3:1
|
3 | / #[cfg(not(any(feature = "contract", feature = "parachain")))]
4 | | compile_error!("feature \"contract\" or feature \"parachain\" must be enabled");
5 | |
6 | | use anyhow::{anyhow, Result};
... |
132 | | }
133 | | }
| |_^
|
= note: requested on the command line with `-W missing-docs`
Check warning on line 287 in crates/pop-cli/src/commands/up/parachain.rs
github-actions / clippy
using `map` over `inspect`
warning: using `map` over `inspect`
--> crates/pop-cli/src/commands/up/parachain.rs:287:5
|
287 | .map(|b| {
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
287 ~ .inspect(|b| {
288 | if latest && b.stale() {
289 | b.use_latest()
290 ~ }
|
Check warning on line 107 in crates/pop-cli/src/commands/up/contract.rs
github-actions / clippy
unnecessary map of the identity function
warning: unnecessary map of the identity function
--> crates/pop-cli/src/commands/up/contract.rs:107:28
|
107 | project_path.as_deref().map(|v| v),
| ^^^^^^^^^^^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
Check warning on line 43 in crates/pop-cli/src/commands/clean.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> crates/pop-cli/src/commands/clean.rs:43:6
|
43 | impl<'a, CLI: Cli> CleanCacheCommand<'a, CLI> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
43 - impl<'a, CLI: Cli> CleanCacheCommand<'a, CLI> {
43 + impl<CLI: Cli> CleanCacheCommand<'_, CLI> {
|
Check warning on line 81 in crates/pop-cli/src/commands/build/mod.rs
github-actions / clippy
unnecessary closure used to substitute value for `Option::None`
warning: unnecessary closure used to substitute value for `Option::None`
--> crates/pop-cli/src/commands/build/mod.rs:81:11
|
81 | path: project_path.unwrap_or_else(|| temp_path).to_path_buf(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
help: use `unwrap_or` instead
|
81 | path: project_path.unwrap_or(temp_path).to_path_buf(),
| ~~~~~~~~~~~~~~~~~~~~
Check warning on line 74 in crates/pop-cli/src/commands/build/mod.rs
github-actions / clippy
unnecessary map of the identity function
warning: unnecessary map of the identity function
--> crates/pop-cli/src/commands/build/mod.rs:74:58
|
74 | if pop_parachains::is_supported(project_path.as_deref().map(|v| v))? {
| ^^^^^^^^^^^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
Check warning on line 62 in crates/pop-cli/src/commands/build/mod.rs
github-actions / clippy
unnecessary map of the identity function
warning: unnecessary map of the identity function
--> crates/pop-cli/src/commands/build/mod.rs:62:57
|
62 | if pop_contracts::is_supported(project_path.as_deref().map(|v| v))? {
| ^^^^^^^^^^^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
= note: `#[warn(clippy::map_identity)]` on by default
Check warning on line 232 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:232:2
|
232 | pub fn license(&self) -> Option<&str> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 228 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:228:2
|
228 | pub fn is_audited(&self) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 222 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:222:2
|
222 | pub fn is_supported_version(&self, version: &str) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 218 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:218:2
|
218 | pub fn supported_versions(&self) -> Option<Vec<&str>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 153 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:153:2
|
153 | OpenZeppelinEVM,
| ^^^^^^^^^^^^^^^
Check warning on line 138 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:138:2
|
138 | OpenZeppelinGeneric,
| ^^^^^^^^^^^^^^^^^^^
Check warning on line 51 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> crates/pop-parachains/src/templates.rs:51:2
|
51 | pub initial_endowment: String,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 50 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> crates/pop-parachains/src/templates.rs:50:2
|
50 | pub decimals: u8,
| ^^^^^^^^^^^^^^^^
Check warning on line 49 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> crates/pop-parachains/src/templates.rs:49:2
|
49 | pub symbol: String,
| ^^^^^^^^^^^^^^^^^^
Check warning on line 33 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:33:2
|
33 | Parity,
| ^^^^^^
Check warning on line 26 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:26:2
|
26 | OpenZeppelin,
| ^^^^^^^^^^^^
Check warning on line 19 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:19:2
|
19 | Pop,
| ^^^
Check warning on line 86 in crates/pop-parachains/src/new_pallet/new_pallet_options.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/new_pallet/new_pallet_options.rs:86:2
|
86 | CustomOrigin,
| ^^^^^^^^^^^^
Check warning on line 84 in crates/pop-parachains/src/new_pallet/new_pallet_options.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/new_pallet/new_pallet_options.rs:84:2
|
84 | GenesisConfig,
| ^^^^^^^^^^^^^
Check warning on line 82 in crates/pop-parachains/src/new_pallet/new_pallet_options.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/new_pallet/new_pallet_options.rs:82:2
|
82 | DefaultConfig,
| ^^^^^^^^^^^^^
Check warning on line 73 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:73:2
|
73 | WorkspaceLocate,
| ^^^^^^^^^^^^^^^