Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release conventions document and refactor CI to run node release separately #433

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Daanvdplas
Copy link
Collaborator

@Daanvdplas Daanvdplas commented Jan 16, 2025

This PR does two things (apologies for not separating them, will do next time).

  1. Lines out the release conventions. View here: https://github.com/r0gue-io/pop-node/blob/daan/docs-release_conventions/docs/release.md
  2. Refactors the CI so that it is clear how to manually run the job to build the release for a node without a runtime build (works). As well as having the CI pickup automatically when a release title is created with node (works).

@Daanvdplas Daanvdplas force-pushed the daan/docs-release_conventions branch from 3ac7338 to 0d1203c Compare January 16, 2025 08:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.41%. Comparing base (8fb843f) to head (f6d78df).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   68.31%   71.41%   +3.10%     
==========================================
  Files          70       72       +2     
  Lines       11764    13568    +1804     
  Branches    11764    13568    +1804     
==========================================
+ Hits         8036     9690    +1654     
- Misses       3470     3605     +135     
- Partials      258      273      +15     

see 20 files with indirect coverage changes

@Daanvdplas Daanvdplas force-pushed the daan/docs-release_conventions branch from 0d1203c to a3036fa Compare January 16, 2025 13:21
@Daanvdplas Daanvdplas marked this pull request as ready for review January 16, 2025 13:21
@Daanvdplas Daanvdplas changed the title docs: release conventions chore: add release conventions document and refactor CI to run node release separately Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants