Test ci/refactor ci #875
Merged
Test ci/refactor ci #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stop using GKE, use local KinD instead - Build single-arch images only when there's a new tag - Wait for cert-manager API to avoid race conditions
Run Linter: rabbitmqclient/vault_reader.go#L116 S1009: should omit nil check; len() for []string is defined as zero (gosimple)
- Install Ginkgo CLI using a step - Add names to publish workflow steps - Add names to PR workflow steps - Update publish API workflow to use a supported output setting method - Use a major floating tag for stale Actions - Delete workflow to publish API reference in main There isn't much value in publishing the API reference from main. Most consumers of this information use release versions. Developers can quickly access the API by deploying the CRDs and running 'kubectl explain'
MirahImage
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
mainAdditional Context
Pushing every DEV version and every commit to DockerHub is excessive, and for little benefit, given how easy and fast is to build locally. After this PR, we only push tagged commits.
Publishing API reference to the Wiki for every commit in
mainis excessive, and provides little value. Most users are interested in GA releases. Any developer who would like to consult the API can do so by installing the CRDs (make install) and runningkubectl explain rmq