Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(IconButton): Add accessibility guidance for aria-labels #844

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

balazsotakomaiya
Copy link

@balazsotakomaiya balazsotakomaiya commented Jan 3, 2025

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code.
  • Include the URL where we can test the change in the body of your PR.

This pull request:

  • Fixes a bug
  • Adds additional features/functionality
  • Updates documentation or example code
  • Other

This PR adds an accessibility callout to the IconButton component documentation, highlighting the importance of using aria-labels for screen reader support. This documentation update is related to the issue raised in radix-ui/themes

The change consists of adding a callout section that guides developers on making IconButton components accessible to screen readers by recommending the use of aria-labels.

Test here

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radix-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 4:15pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant