-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add armoured infantry #21
base: APP6-D
Are you sure you want to change the base?
Conversation
add armoured infantry
Hi, thanks for the PR! Can you please confirm if this is from APP-6(C) or APP-6(D)? I can't find it in APP-6(C) but I might have just missed it. I've been meaning in incorporate the new revision into the package for some time, but I'm thinking about if it would be best to split the changes off into a different file and let users pick the revision with a package option. |
It is displayed APP-6D Thats the description: ARMOURED/MECHANIZED/ |
Thanks! As it's in revision D I'll hold off on any merge for now until I work out how I'm going to integrate both versions into the package. If you're willing to help create more symbols from revision D in the meantime, feel free to add them to the PR (and change the title accordingly) it would be a great help, then I can work on sorting out the structure of the package on the back end. |
It is already stated in APP-6C
So armoured infantry should be allowed as well as armoured engineers. |
I think this is best implemented with a custom icon/modifier for APP-6C since there would be a lot of unique combinations (see the manual for instructions). But as it seems to be specifically defined in APP-6D so I will add it in there. I'm generally going for if the icon is not in a table in the documentation, it's not added as a value in the package. |
add armoured infantry