Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Market summary #2172

Closed
wants to merge 18 commits into from
Closed

Market summary #2172

wants to merge 18 commits into from

Conversation

R5dan
Copy link
Contributor

@R5dan R5dan commented Dec 8, 2024

  • New class for accessing the market summary of an area
    import yfinance as yf
    summary = yf.MarketSummary(region)
    index = summary[index]
    status = index.status
    etc  
  • New class for accessing data from MarketSummary to allow for types

@R5dan
Copy link
Contributor Author

R5dan commented Dec 8, 2024

Don't pull yet, no docs

@R5dan
Copy link
Contributor Author

R5dan commented Dec 8, 2024

Ready

@ValueRaider
Copy link
Collaborator

ValueRaider commented Dec 8, 2024

Can you Git squash commits then rebase to dev branch? #1084 This might block squash: Merge branch 'market-summary' ...

@R5dan
Copy link
Contributor Author

R5dan commented Dec 9, 2024

@ValueRaider sorry, not that good at git. Have tried but can you explain what commands to run. Otherwise I might just make more commits.

@ValueRaider
Copy link
Collaborator

can you explain what commands to run

They're in the link

@R5dan
Copy link
Contributor Author

R5dan commented Dec 9, 2024

They're in the link

I know, I ran them. That's how I got to 21 commits

@ValueRaider
Copy link
Collaborator

When you get other people appearing in the commit history and you don't know why then just start over.

@R5dan
Copy link
Contributor Author

R5dan commented Dec 10, 2024

Ok, sorry about not being very good at git.

@R5dan R5dan changed the base branch from main to dev December 10, 2024 08:14
@R5dan R5dan mentioned this pull request Dec 10, 2024
@R5dan
Copy link
Contributor Author

R5dan commented Dec 10, 2024

@ValueRaider Closing this pr. Check out #2175

@R5dan R5dan closed this Dec 10, 2024
@ValueRaider
Copy link
Collaborator

Can you delete this branch? It will reduce clutter in https://github.com/ranaroussi/yfinance/network

@R5dan R5dan deleted the market-summary branch December 14, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants