-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Earnings Date #2181
Fix: Earnings Date #2181
Conversation
Did you check open pull requests for duplication? |
Yes, I did check for similar pull requests, and I mentioned #2169 in my description. I decided to open this PR because those had no further activity, and I wanted to help move the fix forward. This is the returned table for
|
I tested this out (located in Canada), and while the download works fine, there's an extra row that doesn't seem quite correct in the results: earnings_dates: pd.DataFrame = yf.Ticker("TSLA").get_earnings_dates(limit=100)
print("Earnings Dates\n", earnings_dates)
Update: I forgot to specify which symbol I was using. This is TSLA. |
@AlphaGit Nice catch, has been fixed now. I believe this has to do with Yahoo returning a different table structure compared to before. |
Tested again with a few more assets. Works like a charm! 🎉 |
Hmm this may be a noob question but I installed the branch in a venv and currently getting this error and not sure why, any ideas?
Edit: was trying to install with cloning and pip install -e, instead this worked |
Closing as duplicate #2169 |
Fixes the date and column parsing logic when retrieving Earnings Date.
Changes
parse_earnings_dates
in base.pySurprise(%)
intoSurprise (%)
to maintain backwards compatibilityUsage
The above should match the results from MSFT Earnings
Would appreciate feedback from someone from non EU.
Thanks for the work from #1932 and #2169