Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -i option to docker run to work around bug on Windows #5515

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add -i option to docker run to work around bug on Windows #5515

merged 1 commit into from
Sep 13, 2023

Conversation

jandubois
Copy link
Member

See #3239

@jandubois jandubois requested a review from mook-as September 13, 2023 00:34
mook-as
mook-as approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the bug is specific to another WSL distribution on Windows (i.e. without RD_USE_WINDOWS_EXE).

Just had to clarify because I was looking into a different issue on Windows (outside of WSL)…

@mook-as mook-as merged commit 003c206 into rancher-sandbox:main Sep 13, 2023
@jandubois jandubois deleted the init-container branch September 13, 2023 17:48
@jandubois
Copy link
Member Author

So the bug is specific to another WSL distribution on Windows (i.e. without RD_USE_WINDOWS_EXE).

Yes

Just had to clarify because I was looking into a different issue on Windows (outside of WSL)…

This test was running into #3239. #2094 seems like a different issue. I hope we can address both for 1.11 (or 1.12).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mook-as mook-as mook-as approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jandubois @mook-as