Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM: Don't use %post to set SUID on chrome-sandbox #8040

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Jan 6, 2025

Use RPM-internal specification to set the SUID bit, so that rpm --verify won't flag it as having been modified.

Use RPM-internal specification to set the SUID bit, so that `rpm --verify`
won't flag it as having been modified.

Signed-off-by: Mark Yen <[email protected]>
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but LGTM

@jandubois jandubois enabled auto-merge January 6, 2025 20:17
@jandubois jandubois merged commit 9d8451e into rancher-sandbox:main Jan 6, 2025
20 checks passed
@mook-as mook-as deleted the rpm/chrome-sandbox-suid branch January 6, 2025 21:34
@mook-as
Copy link
Contributor Author

mook-as commented Jan 6, 2025

Ah yeah, I should have mentioned that I tested it in https://build.opensuse.org/package/show/home:mook_work:branches:isv:Rancher:dev/rancher-desktop-main (the _service was updated to use the PR branch).

No matter now, it'll be properly in https://build.opensuse.org/package/show/isv:Rancher:dev/rancher-desktop-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants